bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 1535 in lilypond: [PATCH] Adding the Tweak_engraver tothe Dyna


From: Phil Holmes
Subject: Re: Issue 1535 in lilypond: [PATCH] Adding the Tweak_engraver tothe Dynamics context
Date: Thu, 3 Mar 2011 10:13:20 -0000

"Graham Percival" <address@hidden> wrote in message news:address@hidden

Perhaps we should just say that the Bug Squad should ignore any
"issue to verify" that is tagged with "Patch" ?  we can find
somebody else that can check if a patch was actually pushed.
Cheers,
- Graham

TBH I think that's ducking the issue. Taking 1535 as an example, it was called "Adding the Tweak_engraver to the Dynamics context". If it had been called "Making tweaks work in a Dynamics context" it would have been easier to guess what it was intended to do. If it had included the code you added, it would have taken a moment to test and verify. I think we should work to a standard of easily comprehensible patches with sample code - if we do, any bug squad member would be able to test and verify quickly and we'll have a nice clean list of issues to verify.

--
Phil Holmes
Bug Squad




reply via email to

[Prev in Thread] Current Thread [Next in Thread]