|
From: | lilypond |
Subject: | Re: Issue 1647 in lilypond: |
Date: | Thu, 12 May 2011 00:25:41 +0000 |
Updates: Summary: Labels: -Patch-new Patch-review Comment #6 on issue 1647 by address@hidden: http://code.google.com/p/lilypond/issues/detail?id=1647The patch at the link above now includes an self-documenting option for the old behaviour, and a regression test, and it gives clean `make check`, so it is ready for a third party to review.
I said earlier, wrongly :
I think Mats missed your point that under the old behavior, two flutes playing the same note sometimes resulted in silence.
The old behavior, available in this patch when midiMergeUnisons=##t, was to remove the attack of the second note in an overlapping unison. We didn't hear the new note start, but we did hear the sound continue until both notes were done.
Neither the old code for handling overlapping unisons, nor this new code, catch overlaps when midiChannelMapping = #'instrument (the current default). That means the overlaps remain in the .midi file, so midi2ly can still recreate the orignial .ly file.
[Prev in Thread] | Current Thread | [Next in Thread] |