bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: test of convert-ly


From: Carl Sorensen
Subject: Re: test of convert-ly
Date: Thu, 19 May 2011 18:02:45 -0600

On 5/18/11 11:36 AM, "ggit" <address@hidden> wrote:

> Hi,
> I've done some tests with convert-ly. Could be of use for a next improving. (I
> don't master myself regular expressions).
>  
> Using tools from Lilypond 2-13-61.
> Applying conversion from \version "2.13.31" (to "2.13.51").
> Input file :
>  
> %%%%%%%
>  
> \version "2.13.31"
>  
> %% 0 : comment with the words : converted from \version "2.13.31" on may 18th
>  
> \paper {
>  
> %% 1 : KO 
> top-system-spacing =  #`((space . ,(* 8 mm))(stretchability . 0)(padding . 1))
> %% 2 : OK
> top-system-spacing =  #'((space . 8)(stretchability . 0)(padding . 1))
>  
> %% 3 : comment with the words : foot-separation is obsolete.
> %% 4 : comment with the words : foot-separation.
> %% 5 : comment with this word : foot-separationn
> %% 6 : comment with this word : foot-separatio
> }
> %%%%%%%
>  
> Results :
> -the line 0 *is* converted to ..."2.13.51"..., which is bad to me

This should probably be an enhancement request -- to have convert-ly ignore
lines with comments.  We currently don't have any status checking to see if
we are in a comment or not.

> -the line (after) 1 is *not* converted.

IIRC, this was a choice to not handle potentially troublesome conversions.
But perhaps we should include a NOT_SMART rule, if possible.

> -the line (after) 2 is converted to correct syntax :
> top-system-spacing =  #'((basic-distance . 8)(stretchability . 0)(padding .
> 1))
> -the lines 3, 4 or 5 (in spite of being comments) cause convert-ly to complain
> ("Not smart enough...")

Same as the version string.

Line 5 is a limitation in our convert-ly rules for NOT_SMART, because we
don't restrict ourselves to whole words only.  There is already an issue out
for this -- issue 798.

> -the line 6 is ok (no complain, no conversion) (test after deleting lines 3
> and 4)

Thanks for the test!

Carl




reply via email to

[Prev in Thread] Current Thread [Next in Thread]