Re: Useless test in parser.yy

[David Kastrup]

"Phil Holmes" <address@hidden> writes:

> "David Kastrup" <address@hidden> wrote in message
> news:address@hidden
>>
>> parser.yy contains the following code:
>>
>> music_function_identifier_musicless_prefix: MUSIC_FUNCTION {
>> SCM sig = scm_object_property (yylval.scm, ly_symbol2scm
>> ("music-function-signature"));
>> if (scm_is_pair (sig) && to_boolean (scm_memq (ly_music_p_proc,
>> scm_cdr (scm_reverse (sig)))))
>> {
>> PARSER->parser_error (@$, "Music function applied to event may not
>> have a Music argument, except as the last argument.");
>> }
>> }
>> ;
>>
>> This error check can never trigger
>
> You want this adding to the tracker?

Sort of pointless except for heroics^W statistics.  I just try to make
people comfortable with the thought that I am going to rework that area.

>From the response so far I would think that the intersection of people
reasonably comfortable messing with the parser and being inclined to do
extensive reviews is close to non-existent, so I expect that reviewing,
testing and committing the stuff will mostly be my own job, making sure
that I leave nothing behind that is less maintainable, useful and
documented than before.

It is likely pointless activism to record bugs in the tracker while I am
fixing them.

So no: don't put this in the tracker.  I'll try to confine my bug
reports in future to things that I want to see in the tracker, probably
because fixing them would be out of my comfort zone, at least without
feedback.  So I'll try in future to only report bugs on the bug list
that I actually want put in the tracker.

-- 
David Kastrup