bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 1663 in lilypond: Images missing on web site


From: Colin Campbell
Subject: Re: Issue 1663 in lilypond: Images missing on web site
Date: Mon, 01 Aug 2011 15:43:36 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110617 Lightning/1.0b2 Thunderbird/3.1.11

On 11-07-31 04:49 AM, address@hidden wrote:

Comment #19 on issue 1663 by address@hidden: Images missing on web site
http://code.google.com/p/lilypond/issues/detail?id=1663

Belay comment 17. I think I must have been looking at a page built with make docs. An update:

The web index is in:

file:///home/phil/lilypond-git/build/out-website/index.html

Pictures are referenced as:

<img src="pictures/double-lily-modified3.png" alt="LilyPond logo">

They were:

<img src="../pictures/double-lily-modified3.png" alt="LilyPond logo">

 - so we have lost the ../pictures, as expected.

On both the versions I'm looking at (one built from a git tree of at least a week ago, and one from yesterday) there are no actual pictures visible in the browser. Actually, that's not surprising. The only instances of "double-lily-modified3.png" are in:
  lilypond-git/Documentation/pictures (i.e. the source)
lilypond-git/build/Documentation/pictures/out-www (the website created by make doc) lilypond-git/build/out-www/offline-root/Documentation/pictures (the final website created by make doc and with the links fixed up)

If the make website-built website were to reference these, 1) we would always need to make doc before make website, which rather spoils the point of a slimmed-down make website; 2) we would need to change the links in the website-built html to something like ../Documentation/pictures/out-www, which is rather too specific and out-of-tree.

I think we have 3 options (here presented in my order of preference)

1. Document the fact that make website contains no images (it also has no css, etc.) 2. Write a script that copies the relevant pictures to a out-website/pictures directory and ensure the html links are fixed up correctly. 3. Write a script that fixes the links in out-website to point at the Documentation directory and document that you must run make doc before make website.

What do you think?




I believe the output of make website is *only* complete in out-www/offline-root/, per the CG 4.6.2, Phil. The other paths are explicitly not complete, and I believe the missing .css is covered by that line. When I open out-www/offline-root/index.html in yesterday's build, everything looks as expected, and to Graham's comment, I don't notice any missing images, either locally not on www.lilypond.org.

Cheers,

Colin

--
The human race has one really effective weapon, and that is laughter.
-- Mark Twain




reply via email to

[Prev in Thread] Current Thread [Next in Thread]