bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Issue 1893 in lilypond: Terminates outside_staff_callback early if a gro


From: lilypond
Subject: Issue 1893 in lilypond: Terminates outside_staff_callback early if a grob is outside a slur's X-extent
Date: Sat, 17 Sep 2011 11:14:21 +0000

Status: Accepted
Owner: address@hidden
Labels: Type-Defect Patch-new

New issue 1893 by address@hidden: Terminates outside_staff_callback early if a grob is outside a slur's X-extent
http://code.google.com/p/lilypond/issues/detail?id=1893

Hey all,

This patch fixes the programming error coming from the StrokeFinger discussion.
Currently, none of my outstanding slur work would fix this problem.

The issue is that the offset callback is tacked onto outside-staff objects
before we know if the object falls within the span of the slur.  Thus, even
though these objects are weeded out of slur scoring in score_extra_ecompasses,
the callback function doesn't know they've been weeded out and a separate
weeding out needs to happen.  This patch does that.

I'm not sure where/when/why this behavior would have changed, but I think this
is the appropriate fix.

Cheers,
MS

http://codereview.appspot.com/5056041/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]