|
From: | lilypond |
Subject: | Re: Issue 1988 in lilypond: Patch: Rename \markuplines to \markuplist (before running convert-ly) |
Date: | Tue, 25 Oct 2011 09:40:14 +0000 |
Comment #5 on issue 1988 by address@hidden: Patch: Rename \markuplines to \markuplist (before running convert-ly)
http://code.google.com/p/lilypond/issues/detail?id=1988 ok, I'm convinced, and remove my objection."Patch-needs_work" is just a catch-all for "there is a known disagreement with the patch". The "work" needed could be a rewritten patch, or it could be just a matter of adding comments, discussing stuff, or even just asking people to think about it a bit more. In the latter case, the "work" is done by the reviewer(s), not the patch author.
If the name is misleading, I could go along with renaming it "Patch-objection" or something like that. I thought that "needs work" was a bit "gentler" than "objection", I'm totally open to changing the name.
[Prev in Thread] | Current Thread | [Next in Thread] |