Issue 2037 in lilypond: Patch: Bring argument processing of chord music functions in line with the rest

[lilypond]

Status: New
Owner: ----
Labels: Type-Enhancement Patch-new

New issue 2037 by address@hidden: Patch: Bring argument processing of chord  
music functions in line with the rest
http://code.google.com/p/lilypond/issues/detail?id=2037

Bring argument processing of chord music functions in line with the rest

The previous semantics for music functions called inside of chords
were that any final music arguments were parsed as chord constituents
(not taking durations and being left as NoteEvent instead of
EventChord, with any postevents placed into 'articulations instead of
appended to the EventChord 'elements).  The ongoing unification of
argument processing makes it infeasible to assign a useful meaning to
the phrase "final music arguments" since music and Scheme  
expressions
can be freely interchanged.  Optional argument processing was also
mostly dysfunctional due to implementing that rule without the full
argument processing effort used for music functions elsewhere.

This change makes chord music functions just share the normal argument
processing.  Any EventChord music arguments that could conceivably be
from music _looking_ like a chord constituent (namely an EventChord
containing a single NoteEvent without 'articulation of its own
followed by optional postevents) are repackaged into the form of a
chord constituent and passed in this manner to the music function; all
others left alone.  In order to allow the music function to facilitate
return value of the music function undergoes the same treatment before
getting used inside the resulting chord.

Compatibility to existing usage is excellent.

http://codereview.appspot.com/5373081