bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 1900 in lilypond: Multiple fret-diagram-x markup commands and


From: lilypond
Subject: Re: Issue 1900 in lilypond: Multiple fret-diagram-x markup commands and lilypond safe-mode
Date: Sat, 26 Nov 2011 01:22:21 +0000

Updates:
        Status: Started
        Owner: address@hidden

Comment #3 on issue 1900 by address@hidden: Multiple fret-diagram-x markup commands and lilypond safe-mode
http://code.google.com/p/lilypond/issues/detail?id=1900

There is a patch on Rietveld for review:

http://codereview.appspot.com/5432081

This patch solves the problem by making explicit property declarations for fret-diagram-terse and fret-diagram, rather than using the curried definition of fret-diagram-verbose.

It may have the disadvantage of separating the property definitions from the different fret diagram markup definitions. But I think avoiding the crash is worth it. This may also solve Issue 1997, but I can't test that because 1997 doesn't show up on my system.

No regression test is included, because it requires a special lilypond-book run. But the .lytex file from the original email string is attached, and the first line of the file shows the command to run to test. If no errors occur, the patch is successful.



Attachments:
        safe-mode-crash.lytex  276 bytes




reply via email to

[Prev in Thread] Current Thread [Next in Thread]