bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 1900 in lilypond: Multiple fret-diagram-x markup commands and


From: lilypond
Subject: Re: Issue 1900 in lilypond: Multiple fret-diagram-x markup commands and lilypond safe-mode
Date: Sat, 26 Nov 2011 12:13:00 +0000


Comment #5 on issue 1900 by address@hidden: Multiple fret-diagram-x markup commands and lilypond safe-mode
http://code.google.com/p/lilypond/issues/detail?id=1900

Guess I found it.  in parse-scm.cc we have

internal_ly_eval_scm (Parse_start *ps)
{
  if (ps->safe_)
    {
      static SCM module = SCM_BOOL_F;
      if (module == SCM_BOOL_F)
        {
          SCM function = ly_lily_module_constant ("make-safe-lilypond-module");
          module = scm_call_0 (function);
        }

Note that this module is _not_ protected from garbage collection. It will blow up at some random point of time.

The proper fix depends on whether we want to create a _separate_ lilypond module for each source file, or keep one module throughout.

I'll check in a fix shortly that does _not_ create separate modules since this is the obvious _intent_ of the current code. It may be worth rethinking this.

The minimal fix will just add one line; I'll push it directly to staging.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]