Issue 2089 in lilypond: dangerous redefinition of SCM s / Moment s

[lilypond]

Status: Accepted
Owner: ----
Labels: Type-Maintainability

New issue 2089 by address@hidden: dangerous redefinition of SCM s  
/ Moment s
http://code.google.com/p/lilypond/issues/detail?id=2089

// in music-sequence.cc, line 144
// variable "s" is redefined.  This can be confusing.
// assuming that it's safe to call the second one "start", please push  
directly to staging.
// come to think of it, isn't "l" being redefined too?

Moment
Music_sequence::first_start (SCM l)
{
  Moment m;

  for (SCM s = l; scm_is_pair (s); s = scm_cdr (s))
    {
      Music *mus = unsmob_music (scm_car (s));
      Moment l = mus->get_length ();
      Moment s = mus->start_mom ();   // ************** rename this please
      if (l.to_bool () || s.to_bool ())
        return s;
    }
  return m;
}