bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 2104 in lilypond: Patch: Fix .dep file from lilypond-book when


From: lilypond
Subject: Re: Issue 2104 in lilypond: Patch: Fix .dep file from lilypond-book when include paths are involved.
Date: Thu, 15 Dec 2011 13:01:21 +0000


Comment #6 on issue 2104 by address@hidden: Patch: Fix .dep file from lilypond-book when include paths are involved.
http://code.google.com/p/lilypond/issues/detail?id=2104

I read "CG Section 9. Regression tests" but I can't figure this out: where do you get this diff from?

The "Renaming input to" message is output by lilypond itself. I think that the other messages come from lilypond as well. Lilypond is now given a filename relative to the current directory, and that's what it prints out. I don't immediately see how to force either lilypond or lilypond-book to print filenames relative to the top source directory, as that is completely dependent on the particular layout of the lilypond source tree. But I guess with some hack it could be done.

So given that what you suggest, to output a path relative to the top source directory, would need some sort of hack, which of these second choice options is better:

1) I can probably figure out how to make lilypond print absolute paths for all filenames, to avoid these changes in regtest output.

2) Or we accept that lilypond outputs only the filename relative to the current directory, and look up the current directory from make's output. The script that makes the regtest diff could be modified to hide the renaming. There seems to be something along those lines already in scripts/build/output-distance.py: in class LogFileCompareLink the lines containing "\nProcessing `[^\n]+'\n" are removed.

By the way the build system outputs this already:

make[2]: Entering directory `/home/jrioux/git/lilypond-git/build2/input/regression' make[3]: Entering directory `/home/jrioux/git/lilypond-git/build2/input/regression/midi' make[3]: Leaving directory `/home/jrioux/git/lilypond-git/build2/input/regression make[2]: Leaving directory `/home/jrioux/git/lilypond-git/build2/input/regression'
make[1]: Leaving directory `/home/jrioux/git/lilypond-git/build2/input'

etc.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]