bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 2149 in lilypond: Patch: Creates non-negative-integer? predica


From: David Kastrup
Subject: Re: Issue 2149 in lilypond: Patch: Creates non-negative-integer? predicate.
Date: Thu, 29 Dec 2011 15:42:49 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux)

Ian Hulin <address@hidden> writes:

> On 29/12/11 11:13, address@hidden wrote:
>> 
>> Comment #6 on issue 2149 by address@hidden: Patch: Creates 
>> non-negative-integer? predicate. 
>> http://code.google.com/p/lilypond/issues/detail?id=2149
>> 
>> I'll change it to whatever people think would be easiest - I really
>> have no preference, but I do think it's important to have a
>> user-friendly predicate if LilyPond is to use the box-integral
>> method to create vertical skylines for other objects.
> Why not call it /positive-integer?/ and state in the docstring it defines
> any integer i where i >= 0 as positive.
> Or if you want to stick to Guiles /positive?/, maybe use
> /positive-integer-or-zero?/.
>
> Predicate names seem to work better if they describe what they're
> testing for rather than what's being avoided.
> <Bad pun alert>
> It's better of they're positive . . .
> </Bad pun alert>

Really, I would just use "count?" here and save "a positive integer or
zero" for the documentation string.

-- 
David Kastrup




reply via email to

[Prev in Thread] Current Thread [Next in Thread]