|
From: | lilypond |
Subject: | Re: Issue 2159 in lilypond: Patch: lexer.ll: Warn about non-UTF-8 characters |
Date: | Mon, 02 Jan 2012 16:17:52 +0000 |
Comment #9 on issue 2159 by address@hidden: Patch: lexer.ll: Warn about non-UTF-8 characters
http://code.google.com/p/lilypond/issues/detail?id=2159I pushed a patch removing utf8_char_length and adapting callers. This makes LilyPond somewhat more robust against invalid UTF-8. Callers are still a heap of dirt, but they don't work worse than before, and I don't feel like going through another review for being allowed to bring this crap into a state where people don't complain about _this_ patch because testing it with invalid input makes LilyPond break apart elsewhere like it already did before. Filed an issue with one of the utf8_char_length callers (column numbers are just totally incoherent within LilyPond). It should now be possible to actually test this patch without the rest of LilyPond going up in flames.
[Prev in Thread] | Current Thread | [Next in Thread] |