Re: Issue 1948 in lilypond: Windows install clobbered system PATH

[Keith OHara]

On Tue, 03 Jan 2012 10:10:55 -0800, <address@hidden> wrote:

> Comment #13 on issue 1948 by PhilEHolmes: Windows install clobbered system
> http://code.google.com/p/lilypond/issues/detail?id=1948
>
> OK - it looks like there is nsis code designed to delete the extra entry in
> the path statement, but it's not working AFAICS.  I need GUB to be running
> to test this.

The only thing I see wrong is a trailing ';' in the search for the entry, which 
character will not be the LilyPond entry is last in the list.
<https://github.com/janneke/gub/blob/master/nsis/lilypond.nsi#L243>
And then again a couple lines down when computing how many characters to delete, and then 
if LilyPond was *not* last that could leave a pair of ";;" one of which could 
be removed.

I thought it wisest to have the installer stop touching Windows paths at all, 
but if you and Mike and others can take the time to do better, that' would be 
better.