bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 2171 in lilypond: Patch: Implements DOM-id property for grobs.


From: lilypond
Subject: Re: Issue 2171 in lilypond: Patch: Implements DOM-id property for grobs.
Date: Fri, 06 Jan 2012 10:17:18 +0000


Comment #8 on issue 2171 by address@hidden: Patch: Implements DOM-id property for grobs.
http://code.google.com/p/lilypond/issues/detail?id=2171

I don't think it's good practice to unilaterally bounce patches from staging based on one's personal opinion of the quality of the patch.

No, it isn't, but I can't keep up with reviewing everything in a single day that all contributors keep throwing at LilyPond. It is also not good practice to ignore _all_ standards of coding. If people would not consider it totally fine to just ignore every standard we set up, I would not be appalled to a degree where I act in that manner.

The "documentation" of the whole patch, the "doc-string of the property", is:
+     (DOM-id ,string? "The ID of a DOM node in an XML document.")

There is no other documentation. There are new stencil commands "start-enclosing-DOM-mode", and "end-enclosing-DOM-node". Those are entirely undocumented.

The commit message gives a tiny bit of information but has not been part of the review and is not part of the work tree.

How is _anybody_ supposed to work with that? It is supposed to be a usable feature, isn't it?

Yes, I agree it is bad style to take things from staging after they have passed a countdown. And I wish I would have been faster, and that I would be omnipresent in all reviews. It is much more of a hassle for me as well to fix things after the fact. Things move from staging to master fast.

I _hate_ meddling with those processes and stop the printing presses so to say. But I hate seeing become LilyPond become more of an underdocumented mess than it already is.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]