Re: Issue 2070 in lilypond: Patch: Don't wrap EventChord around rhythmic events by default.

[David Kastrup]

address@hidden writes:

> Updates:
>       Labels: Patch-needs_work
>
> Comment #25 on issue 2070 by address@hidden: Patch: Don't wrap
> EventChord around rhythmic events by default.
> http://code.google.com/p/lilypond/issues/detail?id=2070#c25
>
> Patchy the autobot says: based on current master, this removes the
> pitched grace note from tie-pitched-trill.ly. If it requires current
> staging, then put the patch back to patch-new so a later run will test
> it again.

Ok, this is fun: I have now _all_ regtests working except for the
pitched trill stuff.  song-reordering and other song stuff has different
output; I have to check where that is from.  to-xml has obvious changes.

Here is the remaining problem with the pitched trills:

Processing 
`out/test-results/input/regression/out-test/trill-spanner-pitched-consecutive.ly'
Parsing...
Renaming input to: `trill-spanner-pitched-consecutive.ly'
(make-music
  'SequentialMusic
  'elements
  (list (make-music
          'NoteEvent
          'articulations
          (list (make-music
                  'TrillSpanEvent
                  'pitch
                  (ly:make-pitch 0 4 -1/2)
                  'span-direction
                  -1))
          'duration
          (ly:make-duration 2 0 1 1)
          'pitch
          (ly:make-pitch -1 3 0))
        (make-music
          'NoteEvent
          'articulations
          (list (make-music
                  'TrillSpanEvent
                  'span-direction
                  1))
          'duration
          (ly:make-duration 2 0 1 1)
          'pitch
          (ly:make-pitch -1 3 0))))

Obviously, \relative misses the pitch in the TrillSpanEvent as it does
not bother to look in articulations for it.  Equally obviously, this
means that

\relative c' { <a b\pitchedTrill\startTrillSpan c> ... }

also would have failed previously since then the articulation event
stays in 'articulations here.  So it is just that a bug that has already
been present before has become more visible.

I'll have to see what to do with relative here.  It probably needs to
comb through articulations of NoteEvents (rhythmic events?) for pitches
as well.

-- 
David Kastrup