|
| From: | lilypond |
| Subject: | Re: Issue 2376 in lilypond: Automatic footnotes on \null markups causes unexpected results |
| Date: | Sun, 04 Mar 2012 17:38:10 +0000 |
Comment #10 on issue 2376 by address@hidden: Automatic footnotes on \null markups causes unexpected results
http://code.google.com/p/lilypond/issues/detail?id=2376
To quote from stencil.hh:
* Do not create Stencil objects on the heap. That includes passing
around Stencil* which are produced by unsmob_stencil(). Either
copy Stencil objects, or use SCM references.
It turns out that unsmob_stencil objects _are_ at several places in the
LilyPond source (mostly in the page layout stuff) modified instead of
copied. This is not intended usage. As simple smobs, they are intended to
be entities like numbers: if you want to add to them, create a copy.
Your patch tries to change that design. I don't consider that the correct fix.
| [Prev in Thread] | Current Thread | [Next in Thread] |