|
From: | lilypond |
Subject: | Re: Issue 2364 in lilypond: Patch: Don't use Bottom overrides (default when unspecified) in \tabFullNotation |
Date: | Tue, 06 Mar 2012 08:33:57 +0000 |
Comment #7 on issue 2364 by address@hidden: Patch: Don't use Bottom overrides (default when unspecified) in \tabFullNotation
http://code.google.com/p/lilypond/issues/detail?id=2364I think that is sufficient for verification. The point was that \tabFullNotation establishes global settings useful for typesetting a particular kind of tablature. Because of the now changed lines, you had to call it in a tablature-related context (TabStaff or so?). I think that was even documented, but pointless.
Now I have committed a feature that turns commands like \tabFullNotation into context modifications in an output definition. While the implementation is smart enough to guess a useful "Bottom" context when other context specs precede the overrides/sets in question, relying on such smartness when nothing is gained by it seems unnecessary.
I guess a test would compare the effects of \tabFullNotation on tab contexts when given in a non-tab context, before and after the patch. I don't think that it is worth investing all too much time in this: it does not fix a problem that seems to have bothered anyone so far.
[Prev in Thread] | Current Thread | [Next in Thread] |