bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 2371 in lilypond: Patch: Fix crash when unknown grob name is p


From: lilypond
Subject: Re: Issue 2371 in lilypond: Patch: Fix crash when unknown grob name is passed to ly:engraver-make-grob
Date: Wed, 21 Mar 2012 03:07:20 +0000

Updates:
        Labels: -Patch-countdown Patch-needs_work

Comment #7 on issue 2371 by address@hidden: Patch: Fix crash when unknown grob name is passed to ly:engraver-make-grob
http://code.google.com/p/lilypond/issues/detail?id=2371

David's comment on Rietveld, for reference:
dak     
        3 hours, 29 minutes ago #7

http://codereview.appspot.com/5715053/diff/2001/lily/engraver-scheme.cc
File lily/engraver-scheme.cc (right):

http://codereview.appspot.com/5715053/diff/2001/lily/engraver-scheme.cc#newco...
lily/engraver-scheme.cc:42: programming_error ("cannot create grob");
This gives no helpful indication of where the error occured, and triggers
problems later in unrelated code. That's not better than a segfault: neither is
better than "something that shouldn't happened somewhere".

You could check whether "cause" is a grob in which case you can call unsmob_grob (cause)->programming_error on it in order to give the error message a _source_
indicator, or a stream-event in which case unsmob_event (cause)->origin
()->programming_error would deliver a suitable source indicator for the error.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]