Re: glossary - add 'high bass clef'

[James]

Hello,

On 23 October 2012 12:12, ArnoldTheresius <address@hidden> wrote:
> James wrote
>> Hello,
>>
>> On 23 October 2012 11:29, Wendl, Arnold &lt;
>
>> Arnold.Wendl@
>
>> &gt; wrote:
>>>>ugly, or enhancement request
>>>
>>> I think the "high bass clef" is an important information and should be
>>> added to the music glossary.
>>>
>>> ....
>> Thank you for the patch, I have created
>>
>> http://code.google.com/p/lilypond/issues/detail?id=2921
>>
>> and attached your patch.
>>
>> As I have push access, I'll prepare a patch and put it up for review
>> (as per our process) for you. I'll make sure you are credited with the
>> authorship when it eventually gets pushed.
>>
>> It may take a week or so overall but I'll manage this.
>>
>> James
>>
>> _______________________________________________
>> bug-lilypond mailing list
>
>> bug-lilypond@
>
>> https://lists.gnu.org/mailman/listinfo/bug-lilypond
>
> That's all right.
> I'm some familiar with the prodecure - I did the suggestion for the
> 'incomplete dominant seventh chord', too. So I think I'm allready listed as
> a co-author.
>

Well I have applied this patch and I am not sure it is appropriate for
the glossary, perhaps the explanation, but the example is far too
complex for our documentation - perhaps as a snippet maybe.

Also you have not followed really any of our style guidelines in the
Contributor's Guide (line lengths, texinfo syntax, @lilypond
[variables] etc. so there is still a fair amount of work to do here
before it will even be considered.

So, I can do this for you (shepherd your patch) or you are more than
welcome to use our git-cl and patch review process yourself until you
need to push it, when you will need to prepare a properly formatted
git patch that is easy to apply etc (i notice your $LILYPOND_GIT
variable is not the standard one, making it slightly more work for
those that need to apply it - I am no expert but managed to work it
out). I don't want to discourage you from submitting patches, but we
do have a well defined (if slightly idiosyncratic work-flow - so I am
told, I only know LilyPond so cannot comment)

If you do choose to do this yourself you should read our Contributor's
Guide and follow the style guidelines there, and I suggest that you
take the huge example out, cut it right back as you can and include it
as a snippet.

See:

http://lilypond.org/doc/v2.16/Documentation/contributor/documentation-work

and

http://lilypond.org/doc/v2.16/Documentation/contributor/summary-for-experienced-developers
(the reviews section specifically).

James