bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Documentation/GNUmakefile: Missing dependencies for internals.texi


From: Phil Holmes
Subject: Re: Documentation/GNUmakefile: Missing dependencies for internals.texi
Date: Thu, 13 Dec 2012 17:10:27 -0000

"Johannes Rohrer" <address@hidden> wrote in message news:address@hidden
* 2012-12-13 15:50 +0100 Phil Holmes:
"Johannes Rohrer" <address@hidden> wrote in message
news:address@hidden
> 'make doc' generates the texinfo file for the Internals Reference
> from ly/generate-documentation.ly, which in turn relies on
> scm/document*.scm and their recursive dependencies to do the actual
> work. In the process, settings encoded in various other files get
> documented, e.g. from ly/engraver-init.ly and scm/define-*.scm.
>
> Changes to such files do not necessitate, nor trigger, recompiling
> the LilyPond binary; yet that is the only dependency marked:
>
> --- Documentation/GNUmakefile, lines 287-288 ---
> $(outdir)/internals.texi: $(LILYPOND_BINARY)
> cd $(outdir) && $(buildscript-dir)/run-and-check
> "$(LILYPOND_BINARY) --verbose
> $(top-src-dir)/ly/generate-documentation"
> "generate-documentation.log"
> ---

In this situation, I believe we expect developers to run

make
make doc

rather than have make doc remake the binaries.

But that does not work?

Say, I change scm/translation.scm, one of the files responsible for IR
generation, and nothing else.

The LilyPond binary does not depend on scheme files, so 'make'
(correctly) does NOT recreate it.

Hence, without the added dependencies, neither does 'make doc' recreate
internals.texi.


OK. I assume you've checked this change to the makefile and it a) works and b) doesn't do anything else untoward? If so, I'll put it up for review for you (unless you are able to do it yourself - see http://lilypond.org/doc/v2.17/Documentation/contributor/commits-and-patches#uploading-a-patch-for-review).

--
Phil Holmes
Bug Squad




reply via email to

[Prev in Thread] Current Thread [Next in Thread]