bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: convert-ly rule for \stringTuning


From: David Kastrup
Subject: Re: convert-ly rule for \stringTuning
Date: Wed, 24 Apr 2013 23:29:27 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Federico Bruni <address@hidden> writes:

> I've just happened to update an old score from 2.13.x to latest version
> 2.17.7
> The following custom tuning:
>
> \set TabStaff.stringTunings = #'(2 -3 -5 -8 -13 -20)
>
>
> has been converted to:
>
>
> \set TabStaff.stringTunings = #`(,(ly:make-pitch 0 1 NATURAL)
> ,(ly:make-pitch -1 5 NATURAL) ,(ly:make-pitch -1 4 NATURAL) ,(ly:make-pitch
> -1 2 NATURAL) ,(ly:make-pitch -2 6 NATURAL) ,(ly:make-pitch -2 2 NATURAL) )
>
>
> I wonder why convert-ly has not managed to convert to a more user-friendly
> input, that is:
>
> \set TabStaff.stringTunings = \stringTuning <e, b, e g a d'>

Two reasons: the current notename language is not known.  And
\stringTuning was invented later.

> I'm not able to find the commit which introduced \stringTuning...

Indeed, git log --grep was not helpful.  git blame
ly/string-tunings-init.ly was more helpful and turned up

commit 3170fd65067a96ea861c173c81fce5f0e127762e
Author: David Kastrup <address@hidden>
Date:   Sun Oct 23 15:29:45 2011 +0200

    Get rid of most of the insane string-tunings API

as an actually fabulously useless commit message.


Which is quite younger than

> I found just this old commit:
>
> commit 17f11c2f5ab963bfb07b7652b4860dc4dda5540a
>
> Author: Carl Sorensen <address@hidden>
>
> Date:   Thu Dec 23 08:19:46 2010 -0700
>
>
> The result of convert-ly was intended..
>
>
> * python/convertrules.py
>
>       - Add rule to convert \set stringTunings = #'(...) to
>
>         \set stringTunings = #`((ly:make-pitch x y z)...)
>
>         with ly:make-pitch entries automatically calculated.


-- 
David Kastrup




reply via email to

[Prev in Thread] Current Thread [Next in Thread]