[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fingering overlap - bug?
From: |
David Kastrup |
Subject: |
Re: fingering overlap - bug? |
Date: |
Thu, 28 Nov 2013 20:46:32 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
"Phil Holmes" <address@hidden> writes:
> "Karol Majewski" <address@hidden> wrote in message
> news:address@hidden
>> \version "2.17.96"
>>
>> {
>> \set fingeringOrientations = #'(up) <dis''-1 a''-4 b''-5>1
>> }
>>
>> PS. I want to have all numerals in one column.
>>
>>
>>
>> Karol
>
> I'm afraid this looks like a critical regression, introduced between
> 17.25 and 17.26.
3312ca325600af8adf1fbad1a9546aa1566fab66 is the first bad commit
commit 3312ca325600af8adf1fbad1a9546aa1566fab66
Author: Keith OHara <address@hidden>
Date: Wed Aug 21 13:51:49 2013 -0700
side-position-interface: do not recursively add support
Also remove the call to remove_duplicates() on every addition to a
support list. Reversing unwanted changes from commit 7d3d28d
The named commit is
commit 7d3d28de0ce6e2f018aff599cecd944d1754fe3c
Author: Mike Solomon <address@hidden>
Date: Thu Jan 10 08:54:12 2013 +0100
Makes all side-positioning based on skylines instead of boxes.
The major work is in side-position-interface.cc, with minor
modifications at several places in the code-base to adapt to this.
This allows for snugger positioning of horizontally-oriented
fingerings.
A side-effect of this patch is that side-positioning of all
cross-staff grobs delves into the element list of axis-groups
in order to better guess position, which results in less
collisions (for example, dynamics are less likely to collide
with cross-staff beams).
It would appear that Keith's fix introduced problems of its own.
--
David Kastrup
Re: fingering overlap - bug?, karol, 2013/11/30