Re: How to catch extent of AccidentalPlacement?

[Thomas Morley]

2014-04-15 0:14 GMT+02:00 David Nalesnik <address@hidden>:
> Harm,
>
>
> On Mon, Apr 14, 2014 at 12:07 PM, David Nalesnik <address@hidden>
> wrote:
>>
>>
>>
>> On Mon, Apr 14, 2014 at 8:53 AM, David Nalesnik <address@hidden>
>> wrote:
>>>
>>>
>>> I can't figure out where that 1.1 comes from, though.
>>>
>>
>> This happens in accidental-placement.cc.  It's the value of width
>> calculated in position_apes.  Looks like it doesn't factor in the offsets to
>> the accidentals.
>
>
> Yes, this appears to be the culprit leading to the incorrect values from
> 'X-extent (and calling ly:grob-extent).
>
> Would you mind trying out the attached patch to see if it works in whatever
> context you need AccidentalPlacement info for?
>
> With your example, I get the same values as with 2.16.2, except in the case
> of the five-note chord.  The accidentals in later releases are spaced
> closer, presumably as a result of skyline work.
>
> --David
>

Hi David,

thanks for all your work you've put on this.
I'm ashamed I didn't try it out so far.
I hope I can find the time to do it the next days.

Best,
  Harm