Re: misaligned composer in LP 2.19.14

[David Kastrup]

pls <address@hidden> writes:

> Hey all,
>
> there seems to be a bug in LilyPond 2.19.14: in the following example
> the composer is center-aligned instead of right-aligned:
>
> \version "2.19.14"
>
> \header {
>   composer = "composer"
> }
>
> \score {
>   c'1
> }

Current branch: issue4102
Tracker issue: 4102 (http://code.google.com/p/lilypond/issues/detail?id=4102)
Rietveld issue: 137680043 (https://codereview.appspot.com/137680043)
Issue description:
  Issue 4102: misaligned composer in LP 2.19.14  This problem surfaced
  in the wake of the fix for issue 3855.  It is due to
  Stencil::translate not moving an empty expression even if it has
  non-empty extents so that  \markup fill-line { "" "" "composer" }
  which assembles a line piece by piece and determining the offset of
  the next piece by looking at the end of the assemblage so far lost
  the offset between the first and second "" in the line.   Also
  contains another (not necessary but appropriate) commit  Remove
  redundant check for empty X interval


"composer" is not actually center-aligned: instead its _right_ edge
(rather than its middle) is at the center of the line because the space
between start and center of the line went missing.

Quite hard to track down, caused in an obscure place in C.  Well, seems
like the warning for temporary regressions will apply to 2.19.14, with
the fix only arriving in 2.19.15.

Sorry for that.

-- 
David Kastrup