[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Thumb in fret-diagram

From: Thomas Morley
Subject: Re: Thumb in fret-diagram
Date: Tue, 5 May 2015 00:14:01 +0200

2015-05-04 8:43 GMT+02:00 pls <address@hidden>:
> This looks like a regression to me. See
> https://codereview.appspot.com/4176056/ (allow non numeric fingers (e.g. for
> thumb))
> http://lilypond.org/doc/v2.19/input/regression/dd/lily-caf6e8f6.ly (the ā€œPā€
> is not printed)
> hth
> patrick

Hi Patrick,

thanks for your findings.

This (for me formerly unknown feature) has gone with my patch for issue 2752

It was never documented and the regtest for _exactly_ this was _not_
triggered, as you can read there.

So the first time it came up
I wrote:
I wouldn't call it a regression, because adding and printing strings
in dots was not documented, not really supported (as far as scaling is
concerned) and not covered by a regtest, as far as I can tell.

Therefore I did not pay attention to keep this functionality while
creating the patch for
Issue 2752: Parenthesize dots in fretboards

First, I'll update Issue 4120
label it regression.

Second, provide a patch as soon I'll find some time.

Though, the main question(s):
Why was the regtest not trigered?
Leading to:
Can we trust our regression-tests anymore?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]