Re: Bug

[Mike Solomon]

On 1 February 2017 at 19.04.40, Trevor Daniels (address@hidden) wrote:


Simon Albrecht wrote Wednesday, February 01, 2017 5:49 PM 

> On 01.02.2017 18:08, Mike Solomon wrote: 
> 
>> Yeah, just checked it out, you can remove the spurious if (brain fart). 
>> I don’t have time to propose a patch today but I can do that on Monday if no 
>> one else can get around to it (I haven’t set up git-cl yet on this machine). 
>> Alternatively, I can just push the change to master if people are OK with 
>> that. 
> 
> Shouldn’t at least the normal patch testing be done? 

Yes. This fix isn't urgent, so there's no problem with waiting a few days for 
Mike to set up git-cl and to obtain access to the Issue DB at SF. Mike - 
set up a SF account and post the user name to the Dev list. 

And, Mike, we never push to Master - always to Staging, even after testing. 

Trevor 


Yeah, my bad, it was from reading 
http://lilypond.org/doc/v2.19/Documentation/contributor/uploading-a-patch-for-review

It would help maybe if there was a one-liner specifying that this doesn’t 
actually push to master but rather creates a new branch for review (if that’s 
what that does).

~Mike