Re: midi2ly: Fraction Reduction + 2 minor issues

[Martin Tarenskeen]

On Thu, 13 Apr 2017, Christopher Heckman wrote:

> I have written a patch to fix this. Inside of the class Duration (line
> 129), replace the dump function with:

Hi Chris, thanks for trying to improve the midi2ly tool.

I like the idea and really appreciate your efforts, but I tried your patch 
and it doesn't seem to work (yet), at least not on my system. I can't 
convert a midifile after applying your patch. Did anyone try Christophers 
proposal succesfully? (I installed modified version of midi2ly as 
/usr/bin/midi2ly_ on my system)

Traceback (most recent call last):
  File "/usr/bin/midi2ly_", line 1241, in <module>
    main ()
  File "/usr/bin/midi2ly_", line 1238, in main
    convert_midi (f, o)
  File "/usr/bin/midi2ly_", line 1050, in convert_midi
    s += t.dump (i)
  File "/usr/bin/midi2ly_", line 968, in dump
    return dump_track (self.voices, i)
  File "/usr/bin/midi2ly_", line 881, in dump_track
    s += '  ' + dump_voice (voice, skip)
  File "/usr/bin/midi2ly_", line 781, in dump_voice
    lines[-1] = lines[-1] + dump_chord (ch[1])
  File "/usr/bin/midi2ly_", line 695, in dump_chord
    s = s + dump (notes[0])
  File "/usr/bin/midi2ly_", line 684, in dump
    return d.dump ()
  File "/usr/bin/midi2ly_", line 304, in dump
    s = s + self.duration.dump ()
TypeError: cannot concatenate 'str' and 'NoneType' objects

--

MT