[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 2.19.81 aborts on many .ly files when compiled with gcc8 -Wp, -D_GLI

From: David Kastrup
Subject: Re: 2.19.81 aborts on many .ly files when compiled with gcc8 -Wp, -D_GLIBCXX_ASSERTIONS
Date: Wed, 09 May 2018 13:53:32 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

David Kastrup <address@hidden> writes:

> Mamoru TASAKA <address@hidden> writes:
>> And the attached proposal patch should fix this issue. Please review this.
> Well spotted but this patch is butt-ugly by calculating a nonsense
> reference in the troublesome case that is then being ignored.
> Since neighbor_seg is not even getting used more than twice and that in
> the same expression, I'd just write out segs[j + event_dir] instead and
> let the optimizer do the rest.  The problematic expression is then not
> even generated because of short-circuit evaluation.

I put up a different patch for review.

Tracker issue: 5320 (https://sourceforge.net/p/testlilyissues/issues/5320/)
Rietveld issue: 343160043 (https://codereview.appspot.com/343160043)
Issue description:
  beam.cc: avoid calculating an invalid reference  In
  calc_beam_segments, an invalid reference to a neighboring segment
  was calculated (and not used) at the extreme ends of the beam.  This
  caused segfaults on Fedora.  Since the reference is used at most
  twice anyway and in the same expression, it seems easier to just use
  the expression directly (the invalid cases are then skipped due to
  short-circuit evaluation).

Bug squad?  It might make sense to attach references to the reports in
the mailing list archives to this issue.

David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]