Re: glyph-path-regexp in SVG output is overly strict

[pkx166h]

Jonas,

On 21/02/2020 11:54, Jonas Hahnfeld wrote:
> Am Freitag, den 21.02.2020, 11:50 +0000 schrieb pkx166h:
> > Jonas
> >
> > On 21/02/2020 11:33, Simon Tatham wrote:
> > > Jonas Hahnfeld <
> > > address@hidden
> > > > wrote:
> > > > looking at
> > > > https://sourceforge.net/p/testlilyissues/issues/5779/
> > > >   and
> > > > the grammar you linked, I think the regular expression is also missing
> > > > '+Aa,'. Does it make sense to fuse attached patch?
> > > The idea looks sensible to me, but I think you've made a mistake in the
> > > regular expression syntax. The character '-' has to appear immediately
> > > after the open bracket, otherwise it's taken to be the punctuation in a
> > > range such as "A-Z". So the character class
> > > [+-MmZzLlHhVvCcSsQqTtAa0-9,.Ee\n ] will match (at least) any character
> > > between '+' and 'M'.
> > >
> > > If you start the brackets with [-+Mm...] instead of [+-Mm...] then I
> > > think it does what you intended.
> > >
> > > Cheers,
> > > Simon
> > I am not sure if this will update the tracker as Simon would have to
> > have the correct rights (he only contributes occasionally like this so
> > probably won't be interested in general LP development) the point is
> > that I may have to cut/paste his reply into the tracker if this is the
> > case so others can follow.
> It probably won't... If you don't mind, I'll carry the two commits over
> to Rietveld so we can go through the review cycle and copy Simon's
> reply (which is fully correct!) to SF. Ok?

Be my guest.

It'd take some load off of me and you can talk to Simon in a language he 
will understand.

I did a quick test with Simon's patch (I didn't configure my work 
machine to upload using git-cl so I have no rietveld only the tracker) 
and it did pass all tests.

James