Re: Keys won't display as text in saxophone diagram

[Carl Sorensen]

Here’s a version of display-woodwind-diagrams.scm that I think will work, but I 
don’t know enough about saxophone diagrams to say. Please give it a try.

It would be nice if you could create a regression test that tests all of the 
desired behavior of saxophone diagrams in both text mode and graphical mode.  
Then we would have some way of ensuring things work properly.

With this code

\version "2.20.0"

fingering = \markup \override  #'(graphical . #f)
{
\center-column {
\woodwind-diagram
#'saxophone
#'((cc . (one two three five))
  (lh . ( T bes))
  (rh . ()))
}
}

fingeringGraph = \markup %\override  #'(graphical . #f)
{
\center-column {
\woodwind-diagram
#'saxophone
#'((cc . (one two three five))
  (lh . (T bes ))
  (rh . ()))
}
}

\score {
{
  <g' fis''> ^\fingering
  r r
  <g' fis''> ^\fingeringGraph
}
}

I got what appears to match your desired output in Text mode, as well as the 
proper output in graphical mode (I think).

Carl


From: Antonio Ortega Brook <address@hidden>
Date: Thursday, May 21, 2020 at 9:18 PM
To: Carl Sorensen <address@hidden>
Cc: "address@hidden" <address@hidden>, Valentin Villenave <address@hidden>, 
Valentin Villenave <address@hidden>
Subject: Re: Keys won't display as text in saxophone diagram

This would be the desired output

On Thu, 21 May 2020 at 22:46, Carl Sorensen 
<address@hidden<mailto:address@hidden>> wrote:
What is the desired output?

Carl

From: Antonio Ortega Brook <address@hidden<mailto:address@hidden>>
Date: Thursday, May 21, 2020 at 7:13 PM
To: Carl Sorensen <address@hidden<mailto:address@hidden>>
Cc: "address@hidden<mailto:address@hidden>" 
<address@hidden<mailto:address@hidden>>, Valentin Villenave 
<address@hidden<mailto:address@hidden>>, Valentin Villenave 
<address@hidden<mailto:address@hidden>>
Subject: Re: Keys won't display as text in saxophone diagram

Oh, don't worry, I've already edited the file (just took a look at Valentin's 
merge request to see what was changed).
After fixing this a new issue came up: in text mode, the octave key is 
displayed as a misaligned circle, instead of a T letter.
I paste the code below an attach the output.
Cheers

\version "2.20.0"

fingering = \markup \override #'(graphical . #f) {
\center-column {
\woodwind-diagram
#'saxophone
#'((cc . (one two three five))
  (lh . (T bes))
  (rh . ()))
}
}

\score {
<g' fis''> ^\fingering
}

On Thu, 21 May 2020 at 20:46, Carl Sorensen 
<address@hidden<mailto:address@hidden>> wrote:
Valentin,

Thanks for the quick fix.  I was trying to fix it, but I'm not as fast as you.

If you attach the proper copy of scm/display-woodwind-diagrams.scm to an email, 
 I can give Antonio instructions about how to get the file into the proper 
place on his MacOS.

The instructions:

Browse (using finder) to the folder containing LilyPond.app
Right-click (or control-click) on LilyPond.app, and select "Show Contents"
Click on Resources
Click on Share
Click on lilypond
Click on 2.20.0
Click on scm
Drag the proper copy of display-woodwind-diagrams.scm into the scm/ folder.

This procedure is necessary because I don't think we've ever had a version 
without this typo.

HTH,

Carl



On 5/20/20, 5:42 PM, "Antonio Ortega Brook" 
<address@hidden<mailto:address@hidden>> wrote:

Hello everyone. First of all I think maybe I misunderstood the instructions
for bug reporting and I've opened an issue in GitLab before posting to this
list and now I think that I might not be supposed to do that. I'm very
sorry for the inconvenience.
Anyway, I get the following error when trying to display key names in a
saxophone diagram:

/Applications/LilyPond.app/Contents/Resources/share/lilypond/current/scm/display-woodwind-diagrams.scm:1773:55:
Wrong type argument in position 2 (expecting list): #f
Exited with return code 1.

Example:

\version "2.20.0"

fingering = \markup \override #'(graphical . #f) {
\center-column {
\woodwind-diagram
#'saxophone
#'((cc . (one two four five six))
  (lh . (b))
  (rh . (ees)))
}
}

\score {
<a' aih''> ^\fingering
}

Attached is the expected result.
Best regards
--
Antonio


--
Antonio Ortega Brook


--
Antonio Ortega Brook

display-woodwind-diagrams.scm
Description: display-woodwind-diagrams.scm