Re: musicxml2ly does not honour --no-rest-positions option

[Jonas Hahnfeld]

Am Dienstag, den 28.07.2020, 17:15 +1000 schrieb jostle:
> If musicxml2ly is invoked with the '--no-rest-positions' option it still 
> generates output in the form
> 
> 'c4 \rest' instead of 'r4'
> 
> The following change seems to fix the problem,
> 
> ~/src/lilypond-git$ git diff origin/master
> diff --git a/scripts/musicxml2ly.py b/scripts/musicxml2ly.py
> index ef8ee7562c..4faf2dd566 100755
> --- a/scripts/musicxml2ly.py
> +++ b/scripts/musicxml2ly.py
> @@ -3403,6 +3403,7 @@ def main():
>           conversion_settings.convert_page_breaks = False
>           conversion_settings.convert_page_margins = False
>       conversion_settings.convert_stem_directions = 
> options.convert_stem_directions
> +    conversion_settings.convert_rest_positions = 
> options.convert_rest_positions
> 
>       # Allow the user to leave out the .xml or xml on the filename
>       basefilename = args[0]

This change makes sense to me. Would you be willing to submit this
patch to https://gitlab.com/lilypond/lilypond/ ? If not, just say so
and I will pick it up for you later this week.

Jonas

signature.asc
Description: This is a digitally signed message part