Re: How to shift trill to below phrasing slur?

[Jonas Hahnfeld]

Am Mittwoch, dem 02.12.2020 um 06:40 +0000 schrieb James Lowe:
> On 01/12/2020 21:42, Lukas-Fabian Moser wrote:
> > Hi Harm,
> > 
> > > avoid-slur is the correct method:
> > > 
> > > %#(ly:set-option 'debug-skylines #t)
> > > 
> > > \score {
> > >    {
> > >      \time 12/8
> > >      \relative c' {
> > >        a8 b\( c a b c d e f d e f
> > >        g a b g a b c2.
> > >        \once \override Script.avoid-slur = #'inside
> > >        d2.\trill \grace { c16 d }
> > >        e2.\)
> > >      }
> > >    }
> > > }
> > > 
> > > Though, for unrelated reasons I had enabled 'debug-skylines and
> > > noticed the last part of the PhrasingSlur is not recognized from
> > > skylines. See attached image (done with current master).
> > > A bug?
> > > 
> > > Thus, cc-ing -devel.
> 
> sending to Bug (while there is overlap between dev and bug, it is better 
> it be there than here I think - if nothing else, for historical purposes.

Also tracked at https://gitlab.com/lilypond/lilypond/-/issues/6069. It
turns out the issue also affects regular slurs and I think this makes
the bug Critical in a sense that almost all scores hit this.

It's an off-by-one error in Slur::vertical_skylines and can be solved
by adding a single character
(https://gitlab.com/lilypond/lilypond/-/merge_requests/540), but I
think this means we should not release the stable version 2.22.0
without the fix and an additional 2.21.82. A bit unfortunate, but
better now than discovered by users.

Jonas

> 
> 
> James
> 
> > 
> > That happened with:
> > 
> > 6d76be6462d3595851b0fe3c13ba238b5cdbbddf is the first bad commit
> > commit 6d76be6462d3595851b0fe3c13ba238b5cdbbddf
> > Author: Han-Wen Nienhuys <hanwen@lilypond.org>
> > Date:   Fri May 1 09:09:24 2020 +0200
> > 
> >     Build slur skyline out of segments rather than boxes.
> > 
> >     This provides more precise skylines. The regtest shows 11 images that
> >     changed, with tighter formatting for files involving slurs.
> > 
> >     https://sourceforge.net/p/testlilyissues/issues/5936
> >     http://codereview.appspot.com/577820043
> > 
> > Lukas

signature.asc
Description: This is a digitally signed message part