Re: Articulate.ly misbehaves with trill before full-measure rest

[Jean Abou Samra]

Le 24/04/2022 à 11:09, Martín Rincón Botero a écrit :
> Dear list,
>
> already in 2019 there was a report of articulate.ly 
> (2B7323B8-2288-42B2-8116-0BCE0A45C9AA@getmailspring.com/0?redirect=articulate.ly&recipient=YnVnLWxpbHlwb25kQGdudS5vcmc%3D">https://link.getmailspring.com/link/2B7323B8-2288-42B2-8116-0BCE0A45C9AA@getmailspring.com/0?redirect=articulate.ly&recipient=YnVnLWxpbHlwb25kQGdudS5vcmc%3D)
>  misbehaving when there's a trill followed by a full measure rest. I recently had the same 
> problem in Lilypond 2.22 which was solved with the patch described here: 
> https://marc.info/?l=lilypond-user&m=142477756707049&w=2 
> (2B7323B8-2288-42B2-8116-0BCE0A45C9AA@getmailspring.com/1?redirect=https%3A%2F%2Fmarc.info%2F%3Fl%3Dlilypond-user%26m%3D142477756707049%26w%3D2&recipient=YnVnLWxpbHlwb25kQGdudS5vcmc%3D">https://link.getmailspring.com/link/2B7323B8-2288-42B2-8116-0BCE0A45C9AA@getmailspring.com/1?redirect=https%3A%2F%2Fmarc.info%2F%3Fl%3Dlilypond-user%26m%3D142477756707049%26w%3D2&recipient=YnVnLWxpbHlwb25kQGdudS5vcmc%3D).
> MWE:
> \version "2.22.1"
> \include "articulate.ly"
> \score {
> \unfoldRepeats \articulate {
> b1 \startTrillSpan |
> R1 \stopTrillSpan |
> b2 r |
> b1
> }
> \midi {}
> }
>
> Produces: barcheck failed at: 1/2
> b2 r
> |
> Furthermore, the resulting MIDI is totally wrong after the first full measure rest. 
> Subsequent notes are trilled and rests are ignored. The two lines patch described 
> above solves both problems (failed barcheck and bad playback) perfectly (add to 
> line number 537 of articulate.ly 
> (2B7323B8-2288-42B2-8116-0BCE0A45C9AA@getmailspring.com/2?redirect=articulate.ly&recipient=YnVnLWxpbHlwb25kQGdudS5vcmc%3D">https://link.getmailspring.com/link/2B7323B8-2288-42B2-8116-0BCE0A45C9AA@getmailspring.com/2?redirect=articulate.ly&recipient=YnVnLWxpbHlwb25kQGdudS5vcmc%3D)
>  in master/539 of 2.22.).
> Regards,
> Martín.



Looks good to me. How about submitting this patch as an
actual merge request? Then you'll not only have contributed
it to LilyPond, but you'll also have learnt how to do this
for future contributions. The Contributor's Guide has details:

https://lilypond.org/doc/v2.23/Documentation/contributor/working-with-source-code

Best,
Jean