Re: [courier-users] Re: Build fixes for courier-imap 1.3.2

[Chris Seawood]

Sam Varshavchik wrote:

> Chris Seawood writes:
>
> > I haven't seen these problems mentioned yet (or maybe I missed them). 
> > It looks like preauthchkpw.c will fail to compile if you disabled 
> > roaming user support in vpopmail.  The first patch puts a 
> > POP_AUTH_OPEN_RELAY ifdef around the call to open_smtp_relay().  The 
> > second patch gets rid of
>
>
> I don't know about that one.  Messy solution.

Possibly but you are using a feature from vpopmail that is optional and that is 
the define that's specified in vpopmail_config.h.  At least with vpopmail 
0.8.6, open_smtp_relay() isn't even in vpopmail.h.

> > an extra "-" in the install-configure target. It was causing the build 
> > to fail when using DESTDIR.
>
>
> Your make is broken.  The - is required.

I'm using GNU make 3.79.1 which is currently the latest released version.  

> From the info file:

-->
   The special variables `SHELL' and `MAKEFLAGS' are always exported
(unless you unexport them).  `MAKEFILES' is exported if you set it to
anything.

   `make' automatically passes down variable values that were defined
on the command line, by putting them in the `MAKEFLAGS' variable.

When `make' interprets the value of `MAKEFLAGS' (either from the
environment or from a makefile), it first prepends a hyphen if the value
does not already begin with one.
<--

So at least gnu make is in sync with its documentation.
For clarification (for bug-make), here's the rule

install-configure:
        @echo
        $(MAKE) -$(MAKEFLAGS) install-configure-local DESTDIR=$(DESTDIR)

Here's the result:address@hidden:courier-imap-1.3.2> make install-configure
 DESTDIR=/tmp/foo
make -DESTDIR=/tmp/foo install-configure-local DESTDIR=/tmp/foo
make: invalid option -- D
make: invalid option -- E
make: invalid option -- T
make: invalid option -- D
Usage: make [options] [target] ...
Options: