[bug #15938] functions/foreach test uses non-existent $port_type value

[greg keranen]

URL:
  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=15938>

                 Summary: functions/foreach test uses non-existent $port_type
value
                 Project: make
            Submitted by: gkeranen
            Submitted on: Wed 03/01/06 at 04:20
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
       Component Version: CVS
        Platform Version: Any
           Fixed Release: None

    _______________________________________________________

Details:

--- TEST ENVIRONMENT:
GNU make on CYGWIN_NT-5.1 x2 1.5.19(0.150/4/2) i686
GNU Make 3.81rc1

--- ANALYSIS:
tests/scripts/functions/foreach includes the code:
    # On WIN32 systems, the user's path is found in %Path% ($Path)
    #
    $pathvar = (($port_type eq 'Windows') ? "Path" : "PATH");

'Windows' is not a value that $port_type ever contains.

--- PROPOSED FIX:
    $pathvar = (($port_type eq 'W32') ? "Path" : "PATH");

--- PROBLEM WITH PROPOSED FIX - INCOMPATIBLE WITH FIX FOR BUG #15937:

    If $port_type eq 'W32' on Cygwin, one of the foreach tests fails.
    
    In Cygwin bash environment only PATH and not Path exists. 
    QUESTION: Does this same issue apply to MinGW (also identified as 'W32')    
        


functions/foreach ....................................... FAILED (3/4
passed)

--- FILE: work/functions/foreach.diff:

*** work/functions/foreach.base Tue Feb 28 14:19:06 2006
--- work/functions/foreach.log  Tue Feb 28 14:19:06 2006
***************
*** 1,2 ****
! undefined file default file environment default file command line override
automatic automatic
! foo.o bletch.o null.o @.o garf.o .o    .o undefined.o file.o default.o
file.o environment.o default.o file.o command.o line.o override.o automatic.o
automatic.o
--- 1,2 ----
! undefined file default file undefined default file command line override
automatic automatic
! foo.o bletch.o null.o @.o garf.o .o    .o undefined.o file.o default.o
file.o undefined.o default.o file.o command.o line.o override.o automatic.o
automatic.o






    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 03/01/06 at 04:20  Name: foreach  Size: 2.29KB   By: gkeranen
foreach - with proposed fix applied
<http://savannah.gnu.org/bugs/download.php?item_id=15938&item_file_id=3456>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=15938>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/