[bug #15947] tests/features/escape - 'path=p\:' test fails on Cygwin - cannot stat illegal filename

[greg keranen]

URL:
  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=15947>

                 Summary: tests/features/escape - 'path=p\\:' test fails on
Cygwin - cannot stat illegal filename
                 Project: make
            Submitted by: gkeranen
            Submitted on: Wed 03/01/06 at 14:12
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
       Component Version: CVS
        Platform Version: MS Windows
           Fixed Release: None

    _______________________________________________________

Details:

--- TEST ENVIRONMENT:
GNU Make 3.81rc1 on CYGWIN_NT-5.1 x2 1.5.19(0.150/4/2) i686

--- STEPS TO REPRODUCE
address@hidden tests]$ ./run_make_tests features/escape
------------------------------------------------------------------------------
    Running tests for GNU make on CYGWIN_NT-5.1 x2 1.5.19(0.150/4/2) i686
                               GNU Make 3.81rc1
------------------------------------------------------------------------------

Clearing work...
Making work dirs...

features/escape ......................................... FAILED (5/6
passed)

1 Test in 1 Category Failed (See .diff files in work dir for details) :-(

--- FILE: work/features/escape.diff.2

*** work/features/escape.base.2 Wed Mar  1 05:59:37 2006
--- work/features/escape.log.2  Wed Mar  1 05:59:37 2006
***************
*** 1 ****
--- 1,3 ----
+ make: stat: p:foo: No medium found
  cp p:foo
+ make: stat: p:foo: No medium found

--- ANALYSIS:
':' is an illegal filename character on W32 filesystem
make tries to stat the target and fails on W32

--- PROPOSED FIX:
File attached: tests/features/escape - added $port_type != 'W32'

Wrap test in test for filesystem compatibility: $port_type != 'W32'

# 2006.03.01 address@hidden - fix error of 'make: stat: p:foo: No medium found'
in Cygwin
# CAVEAT: this may also fail on other systems. May need to filter out other
$port_type values
if ($port_type != 'W32' && $port_type != 'DOS')
{
        # TEST 3: This one should work, since we escape the ":".
        &run_make_with_options($makefile, "'path=p\\:'", &get_logfile, 0);
        $answer = "cp p:foo\n";
        &compare_output($answer,&get_logfile(1));
}

--- REGRESSION TEST: SUCCESSFUL
address@hidden tests]$ ./run_make_tests features/escape
[...]
features/escape ......................................... ok     (5 passed)

--- CAVEAT: 
This may also fail on other systems where ':' is illegal filename char
May need to filter out other $port_type values






    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 03/01/06 at 14:12  Name: escape  Size: 1.94KB   By: gkeranen
tests/features/escape - added $port_type != 'W32' &amp;&amp; $port_type !=
'DOS'
<http://savannah.gnu.org/bugs/download.php?item_id=15947&item_file_id=3460>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=15947>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/