bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug #15718] Weird behavior of the SHELL variable on Win32


From: Eli Zaretskii
Subject: Re: [bug #15718] Weird behavior of the SHELL variable on Win32
Date: Sat, 04 Mar 2006 21:38:36 +0200

> Date: Sat,  4 Mar 2006 20:17:20 +0200
> From: Eli Zaretskii <address@hidden>
> 
> The fact that it doesn't work with setting SHELL from the command line might
> mean there's another place in the code where the special treatment of cmd
> should be added.  Hmmm...

Fixed thusly:

2006-03-04  Eli Zaretskii  <address@hidden>

        * variable.c (do_variable_definition) [WINDOWS32]: Call the shell
        locator function find_and_set_default_shell if SHELL came from the
        command line.


--- variable.c~ 2006-02-17 17:29:52.000000000 +0200
+++ variable.c  2006-03-04 20:46:50.248500000 +0200
@@ -1167,7 +1167,8 @@ do_variable_definition (const struct flo
   else
 #endif /* __MSDOS__ */
 #ifdef WINDOWS32
-  if ((origin == o_file || origin == o_override) && streq (varname, "SHELL"))
+  if ((origin == o_file || origin == o_override || origin == o_command)
+      && streq (varname, "SHELL"))
     {
       extern char *default_shell;
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]