bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #16476] Inconsistent function macros - again


From: J
Subject: [bug #16476] Inconsistent function macros - again
Date: Mon, 1 May 2006 15:21:29 +0000
User-agent: Mozilla/5.0 (X11; U; GNU/Linux i686; en; rv:1.7.12) Gecko/20051013 Debian/1.7.12-1ubuntu1

Follow-up Comment #1, bug #16476 (project make):

Hi!

> I assume that WINDOWS32 is for MS compiler support - not for WIN32
specific
> code. I also see that changes have been made in the CVS source, at least
in
> make.h - so take this for what it is. 

WINDOWS32 is for win32 builds, be they compiled by gcc, MSVC or another
compiler for the win32 platform.

> If I may suggest:
> Remove the WINDOWS32 conditional all together - it is not needed.
> For WIN32 specific parts there are already 2 constants defined:
> _WIN32 - internal constant defined for WIN32 binaries
> WIN32 - defined in the Windows SDK for the WIN32 API
> Both is defined and needed when compiling a WIN32 GNU make

Potentialy it could be replaced if there was one which would already be
defined, depends if someone wants to go through the code and make that change
really IMHO.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=16476>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]