[bug #21823] Potential NULL pointer dereference on hash.c, hash_insert

[Paul D. Smith]

Follow-up Comment #3, bug #21823 (project make):

This is confusing, and the lack of detailed comments in hash.c doesn't help.

However, I think this particular bug is impossible.  Looking at the
implementation of hash_find_slot(), it seems there is no way for that function
to return null.  So, the test in hash_insert() to see if slot is null is
unneeded and we can never pass null to hash_insert_at() from hash_insert().

That useless check in hash_insert() should be removed to avoid a bit of
confusion and a useless operation or two.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?21823>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/