bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug #27809] several win64 fixes


From: Ozkan Sezer
Subject: Re: [bug #27809] several win64 fixes
Date: Fri, 9 Jul 2010 13:34:18 +0300

On Fri, Jul 9, 2010 at 1:30 PM, Eli Zaretskii <address@hidden> wrote:
>> Date: Fri, 9 Jul 2010 13:18:12 +0300
>> From: Ozkan Sezer <address@hidden>
>> Cc: address@hidden, address@hidden
>>
>> On Fri, Jul 9, 2010 at 1:17 PM, Ozkan Sezer <address@hidden> wrote:
>> > On Fri, Jul 9, 2010 at 1:00 PM, Eli Zaretskii <address@hidden> wrote:
>> >>> Date: Mon, 05 Jul 2010 21:42:52 +0300
>> >>> From: Eli Zaretskii <address@hidden>
>> >>> Cc: address@hidden, address@hidden, address@hidden
>> >>>
>> >>> > From: "Paul D. Smith" <address@hidden>
>> >>> > Date: Mon, 05 Jul 2010 18:32:15 +0000
>> >>> >
>> >>> >
>> >>> > Follow-up Comment #9, bug #27809 (project make):
>> >>> >
>> >>> > I've applied most of the second patch.  The first patch is mostly in 
>> >>> > the w32
>> >>> > area so maybe Eli is a better person to review it?
>> >>>
>> >>> I will try to do that over the next few days.
>> >>
>> >> I have a question regarding this patch:
>> >>
>> >>  diff -u -p -r2.27 config.h.W32.template
>> >>  --- config.h.W32.template     25 Oct 2009 18:56:44 -0000      2.27
>> >>  +++ config.h.W32.template     5 Jul 2010 19:43:20 -0000
>> >>  @@ -426,7 +426,11 @@ this program.  If not, see <http://www.g
>> >>   /* Define to `int' if <sys/types.h> does not define. */
>> >>   /* GCC 4.x reportedly defines pid_t.  */
>> >>   #ifndef _PID_T_
>> >>  +#ifndef _WIN64
>> >>   #define pid_t int
>> >>  +#else
>> >>  +#define pid_t __int64
>> >>  +#endif
>> >>   #endif
>> >>
>> >> Why is this needed?  Is there really a MinGW64 port of GCC whose
>> >> version is less than 4?  If MinGW64 only has GCC 4.x or later, it is
>> >> supposed to define pid_t in the header files supplied with GCC.
>> >> Please check.
>> >>
>> >
>> > Yes there is: w64 is supported since gcc-4.4 (even 4.3 may
>> > be used but very limited so that doesn't count) and I am really
>> > amazed how people doesn't know that. So, for the record,
>> > everything that I posted here are regarding gcc, not any other
>> > compiler. Oh, and for the runtime, headers, etc. regarding w64-
>> > gcc, go to: mingw-w64.sourceforge.net
>> >
>>
>> Oh, oh sorry... W64 port with gcc < 4.x:  That part no, there is not.
>
> So am I right assuming that the the _WIN64 part of the above change is
> not needed, because MinGW64 will use the pid_t defined in the compiler
> headers?
>
> IOW, is the following good enough to satisfy MinGW64?
>
>    /* Define to `int' if <sys/types.h> does not define. */
>    /* GCC 4.x reportedly defines pid_t.  */
>    #ifndef _PID_T_
>    #define pid_t int
>    #endif
>

MinGW64 maybe, but considering that the config.h.W32.template file
is actually intended for m$vc, I'd say the win64 ifdef is really needed.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]