[bug #30323] No path in MAKE_COMMAND (with fix)

[anonymous]

Follow-up Comment #3, bug #30323 (project make):

Hi Eli,

> GetModuleFileName is available on Windows 9X as well.

I see. Thanks for the hint.

> So I think the current code is allright even on older Windows versions. 

> If you have a practical case weher this API doesn't work on Windows 9X,
please show the Makefile and the error messages. 

I'm quite sure that there's a misunderstanding :-(

The current code doesn't use GetModuleFileName() _NOR_ the proposed _pgmptr.
Therefore it is certainly compatible with older Windows versions.

My proposal is to use one _OR_ the other instead of the current code using
argv[0]. So I was only caring about the compatibility of my proposal with
older Windows versions.

My proposal makes sure that MAKE_COMMAND always contains an absolute path
regardless of circumstances under which GNU make was called.

As far as I see there's no need to discuss/prove that an absolute path in
MAKE_COMMAND is desirable as the current code itself contains a comment
pointing out (one incarnation of) the problem:

"If it is a name with no slash, we can only hope that PATH did not find it in
the current directory." 

Oliver Schmidt - oliv.schmidt(at)sap.com

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?30323>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/