[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Intermittent parallel make rebuild failures

From: David Highley
Subject: Re: Intermittent parallel make rebuild failures
Date: Sun, 10 Oct 2010 06:23:29 -0700 (PDT)

"Philip Guenther wrote:"
> Looking backwards, this rule from your top level makefile:
> seems bogus, given that $(INF_DIST_SVCS_OBJS) is a list of objects in
> directories _below_ the list of directories in $(DIRS).  The top level
> make may recurse, then on popping back out see that the *SOURCE
> DIRECTORY* didn't change, and thereby decide that the object must not
> have changed.

OK, the fix ended up being fairly minor to implement. We replaced the
$(DIRS) target with:
        @$(SET_E); $(MKDIR) $(@D); cd $(@D)/.. && \
            PATH=$(PATH) "$(MAKE)" $(OBJDIR)/$(@F)

Had to create another macro $(INF_DIST_SVCS_SCRS) which is defined as:
INF_DIST_SVCS_SCRS      = $(foreach DIR,$(DIRS),$(wildcard $(DIR)/*.cpp))

We still need to had a filter capability to the macro yet. Testing has
shown this to be solid and you get the message that your object file is
up to date for each object file that does not need to change.

> It looks me like your makefile is misleading make.
> Can you give examples of the output of make when this stuff *isn't*
> working?  Preferable minimal, of course, where only a single source
> file was changed/recompiled, showing how make failed to rebuild
> everything that it you wish it would, and then the output of the
> second make invocation that builds the missing piece?ou
> I don't trust dependencies on directories; you have a dependency on a
> directory WHOSE CONTENTS AREN'T BEING CHANGED.  That raises florescent
> red flags to me.
> Philip Guenther

reply via email to

[Prev in Thread] Current Thread [Next in Thread]