bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix for make gaining jobserver tokens


From: Tim Newsome
Subject: Re: fix for make gaining jobserver tokens
Date: Mon, 14 Nov 2011 11:08:25 -0800

On Sun, Nov 13, 2011 at 4:19 PM, Paul Smith <address@hidden> wrote:
On Tue, 2011-10-25 at 13:34 -0700, Tim Newsome wrote:
> We do a lot of builds (as in double-digit servers building non-stop).
> Sometimes, when a part of the build fails, make -j8 would die with:
> make: INTERNAL: Exiting with 9 jobserver tokens available; should be
> 8
>
> With -j16 the error would be 17 instead of 16, etc. I think it's
> simply an off-by-one error in cleanup code that is almost never run.
> Attached is a patch that fixes it. We've been running with it for over
> 5 days now and haven't noticed any problems.

I applied a change to fix this.  I tried for a while but couldn't
generate a repro case.  Bummer.

Great. Thank you. I never had a reliable test case either. It mainly seemed to happen when a process make started segfaulted.

Tim

reply via email to

[Prev in Thread] Current Thread [Next in Thread]