[bug #34832] enable tls variable in windows code for newish gcc

[Eli Zaretskii]

Follow-up Comment #21, bug #34832 (project make):

Ozkan,

I don't understand the emotions.  This is supposed to be a technical
discussion.  If I said something that sounded offensive, I apologize.

More to the point: I don't know why it is there.  1996 is way before I started
to be interested in the Windows port of Make, certainly well before I began
contributing.  ChangeLog says that my first contribution to the Windows port
was in 2005.

"cvs annotate" shows that this TLS thing was in w32err.c since its first
version was contributed by Rob Tulloh when the Windows port was first added to
Make.  The commented-out calls to map_win32_error_to_string were already
commented-out in that original commit, again according to "cvs annotate".

Moreover, as someone already mentioned here, process_pipe_io, the only
function that launches additional threads, is never called by Make.  (I will
ifdef it away when I have time.)

The only situation I'm aware of when more than a single thread is running in
Make is when you hit Ctrl-C while Make runs, which on Windows creates a
separate thread to run the signal handler.  But the first thing that handler
does is stop the main thread in its tracks, so that the two threads don't step
on each other's toes.

So, as far as Make is concerned, the situation with several threads trying to
write to the same static buffer was never tested, neither with MSVC nor with
GCC.

Given all this, if someone still thinks we should enable TLS for GCC, I'm
willing to accept the patch, since it obviously cannot do any harm.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?34832>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/