Re: [PATCH]: Continuing touching files after an error

[Atte Peltomäki]

On Sat, Dec 10, 2011 at 12:17:14PM -0500, Paul Smith wrote:
> On Wed, 2011-12-07 at 16:04 +0200, Atte Peltomäki wrote:
> > Hello,
> > 
> > here's a small fix for a corner case I happened to run into.
> > 
> > Scenario:
> > 
> >  Run 'make -t' on an incomplete tree, where a dependency file and 
> >  the subdirectory it should be in, are completely missing. Make fails
> >  and exits.
> > 
> > Problem:
> > 
> >  Run 'make -t -k' to have make continue despite missing dependency.
> >  Doesn't work, it still exits early.
> 
> Hi Atte.  I don't think this patch is right.  It doesn't seem proper to
> me to skip things like notice_finished_file() etc. when -k is provided.
> 
> I couldn't quite reproduce the error situation you described.  Can you
> provide me with a simple makefile that shows the problem?

Sure, here: 

ronsu:~/test> cat Makefile
default: missingdep/dep1 dep2

missingdep/dep1:
        gcc missingdep/dep1.c -o missingdep/dep1

dep2:
        gcc dep2.c -o dep2

ronsu:~/test> make -t
touch missingdep/dep1
make: touch: open: missingdep/dep1: No such file or directory

ronsu:~/test> make -t -k
touch missingdep/dep1
make: touch: open: missingdep/dep1: No such file or directory
make: Target `default' not remade because of errors.

-- 
Atte Peltomäki
     address@hidden <> http://kameli.org
"Your effort to remain what you are is what limits you"