[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Loading dynamic objects on Windows

From: Paul Smith
Subject: Re: Loading dynamic objects on Windows
Date: Fri, 03 May 2013 10:54:23 -0400

On Fri, 2013-05-03 at 16:13 +0300, Eli Zaretskii wrote:
> > The two problems I discovered and fixed are:
> No comments, so I went ahead and pushed these changes (see commit
> a66469e).

Thanks Eli.  I hadn't gotten around to examining those comments in
detail.  In general I was OK with what I read with one exception: I'm
not so excited about adding a new pointer to the file structure, which
is an extra 8 bytes (on 64bit hardware) for every file struct for the
rare situation that the file represents a loaded shared object.  Make
already uses far too much memory, IMO.

I would prefer to do something like use a boolean bit in the file object
to specify that it refers to a shared object, and keep the pointers in a
different structure.  Then if the bit is set we can take the hit of
looking up the pointer; this will be very rare anyway.

I can look into this more this weekend.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]