Re: [bug #33138] .PARLLELSYNC enhancement with patch

[Eli Zaretskii]

> Date: Sat, 04 May 2013 04:42:32 +0200
> Cc: address@hidden, address@hidden, address@hidden
> From: Frank Heckenbach <address@hidden>
> 
> :   /* This is needed to avoid the "label at end of compound statement"
> :      diagnostics on Posix platforms.  */
> 
> I don't think that's a POSIX thing (which is a standard about
> operating systems, not compiler diagnostics), is it?

You quote this out of context, which is this:


   finished:

  #ifdef WINDOWS32
    /* Switch to_fd back to its original mode, so that log messages by
       Make have the same EOL format as without --output-sync.  */
    _setmode (to_fd, prev_mode);
  #endif

    /* This is needed to avoid the "label at end of compound statement"
       diagnostics on Posix platforms.  */
    return;
  }

I used "Posix platforms" here (not just POSIX the name of the
standard) in contrast to WINDOWS32, where there's some code between
the label and the closing brace, which prevents the (stupid, IMO)
warning.

> Also, I think in the Windows branch, the former condition also
> should say just "output_sync" instead of
> "output_sync == OUTPUT_SYNC_TARGET", a recent change during the
> introduction of "-O job".

You are right.  This is a consequence of having 2 separate branches in
the code.  I fixed this one.