[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

From: Eli Zaretskii
Subject: Re: [PATCH 2/2] Do not use DOS paths on Cygwin
Date: Tue, 06 Aug 2013 18:02:29 +0300

> From: Pavel Fedin <address@hidden>
> Cc: address@hidden, address@hidden
> Date: Tue, 06 Aug 2013 17:46:14 +0400
> 1. abspath on Cygwin returns UNIX-style paths and on pure DOS/Windows -
> DOS-style.

This is what I'd expect.

> If DOS-style absolute path is already supplied, it will leave it as
> is.

Again, this is what I'd expect.

> 2. PATH_SEPARATOR on Cygwin is ':' and on pure DOS/Windows is ';'.

This is true, but how is this relevant to the issue at hand?
'abspath' does not deal with PATH-style directory lists, it accepts a
single file name as its argument.  What am I missing here?

>  In order to distinguish between these two i have added one more test to
> configure. It attempts to compile and run a small program which checks
> whether result of getcwd() is DOS-style. In case of cross-compiling it just
> knows that for DOS and MinGW native path style is DOS. Of course
> config.cache value is taken into account.
>  Technically it is possible to work around (2) using some clever heuristics,
> but i don't see how it would be possible to determine whether e.g. /foo/bar
> is an absolute path of DOS-style relative one.
>  Will this solution be OK ?

It probably would, if you do a clean job, but frankly I'm not sure
it's worth your while.  It is so easy to glean this information by
just looking at the appropriate preprocessor macro, like WINDOWS32
etc. that a configure-time test sounds like overkill.  But I won't
object to such a test, FWIW.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]